Skip to content

Fix serializable check & Add test cases#12054

Merged
AlbumenJ merged 8 commits intoapache:3.1from
AlbumenJ:0406_serialize
Apr 11, 2023
Merged

Fix serializable check & Add test cases#12054
AlbumenJ merged 8 commits intoapache:3.1from
AlbumenJ:0406_serialize

Conversation

@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Apr 10, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ mentioned this pull request Apr 10, 2023
Open
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.17241% with 26 lines in your changes missing coverage. Please review.

Project coverage is 64.90%. Comparing base (e3e7ce8) to head (9433d01).
Report is 20 commits behind head on 3.1.

Files with missing lines Patch % Lines
...java/org/apache/dubbo/common/utils/ClassUtils.java 62.50% 5 Missing and 10 partials ⚠️
...mmon/serialize/fastjson2/FastJson2ObjectInput.java 30.00% 6 Missing and 1 partial ⚠️
...mon/serialize/hessian2/Hessian2FactoryManager.java 25.00% 3 Missing ⚠️
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.1   #12054      +/-   ##
============================================
+ Coverage     64.68%   64.90%   +0.21%     
  Complexity       14       14              
============================================
  Files          1433     1433              
  Lines         60086    60124      +38     
  Branches       8832     8853      +21     
============================================
+ Hits          38868    39021     +153     
+ Misses        17127    16994     -133     
- Partials       4091     4109      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

13.6% 13.6% Coverage
0.9% 0.9% Duplication

chickenlj
chickenlj approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit f0f01c3 into apache:3.1 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chickenlj chickenlj chickenlj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlbumenJ @codecov-commenter @chickenlj